remove create_sync_endpoint, run sync functions in background thread #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove some code duplication by removing
create_sync_endpoint
. Instead wrap synchronous function calls in a decorator which executes them asynchronously through a background thread usingstarlette.concurrency.run_in_threadpool
. This means all endpoint handlers used by async or sync backends will be executed asynchronously.FastAPI also executes synchronous endpoint handlers in background threads, so this should behave the same as before but with one less code path.
PR Checklist:
pre-commit run --all-files
)make test
)make docs
)