Set content-type to geojson for search results #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7815e90 to
a1e4038
Compare
lossyrob
requested changes
Nov 10, 2021
| @@ -175,12 +181,12 @@ def register_post_search(self): | |||
| response_model=(ItemCollection if not fields_ext else None) | |||
| if self.settings.enable_response_models | |||
| else None, | |||
| response_class=self.response_class, | |||
| response_class=GeoJSONResponse, | |||
There was a problem hiding this comment.
This will cause the GeoJSONResponse to not use ORJSONResponse if the self.response_class is ORJSONResponse, leading to slowdowns in what's the largest API responses.
Is there a way to just set the media_type at response class creation time instead of setting the media type through this mechanism?
There was a problem hiding this comment.
To resolve this, I've used importlib to conditionally use ORJSONResponse when orjson is available and JSONResponse otherwise.
lossyrob
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #220
Description:
This PR changes the /search endpoint's headers to reflect the fact that it returns geojson rather than mere json, which is in line with the STAC api spec
PR Checklist:
pre-commit run --all-files)make test)make docs)