Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection links in the return of the collection list endpoint #269

Conversation

aaronxsu
Copy link
Contributor

@aaronxsu aaronxsu commented Sep 20, 2021

Related Issue(s): #266

Description:
This PR fixes the pgstac's collection list method so that the returned Collections includes the correctly processed links in each Collection.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

Add test

Update changelog
@aaronxsu aaronxsu force-pushed the feature/asu/fix-all-collections-in-pgstac branch from 52265f7 to d9ac1df Compare September 20, 2021 20:25
@moradology moradology self-requested a review September 20, 2021 21:40
Copy link
Member

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

aaronxsu and others added 4 commits September 21, 2021 09:27
Add test

Update changelog
Co-authored-by: Nathan Zimmerman <npzimmerman@gmail.com>
…m:aaronxsu/stac-fastapi into feature/asu/fix-all-collections-in-pgstac
@moradology moradology merged commit 2ffaf12 into stac-utils:master Sep 21, 2021
@aaronxsu aaronxsu deleted the feature/asu/fix-all-collections-in-pgstac branch September 21, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants