Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #259 (stac_validator error NULL in title element #260

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Fix #259 (stac_validator error NULL in title element #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
499d4c4
* Modified BaseCoreClient::landing_page to add the collection.get('id…
briangmaddox Sep 9, 2021
80f33e2
* Modified the test as per stac_validator, NULL strings as titles is …
briangmaddox Sep 9, 2021
4eaacfa
Merge branch 'master' into 259_validator_none_in_title_element
geospatial-jeff Sep 13, 2021
2715a1e
Update CHANGES.md
geospatial-jeff Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* Pin FastAPI to 0.67 to avoid issues with rendering OpenAPI documentation ([#246](https://github.com/stac-utils/stac-fastapi/pull/246))
* Restrict `limit` parameter in sqlalchemy backend to between 1 and 10,000. ([#251](https://github.com/stac-utils/stac-fastapi/pull/251))
* Fix OAS conformance URL ([#263](https://github.com/stac-utils/stac-fastapi/pull/263))
* Links to children collections from the landing pagge always have a title ([#260](https://github.com/stac-utils/stac-fastapi/pull/260))

## [2.1.0]

Expand Down Expand Up @@ -70,4 +71,4 @@ _2020-09-25_
[2.1.0]: <https://github.com/stac-utils/stac-fastapi/compare/2.1.0..main>
[2.0.0]: <https://github.com/stac-utils/stac-fastapi/compare/1.1.0..2.0.0>
[1.1.0]: <https://github.com/stac-utils/stac-fastapi/compare/1.0.0..1.1.0>
[1.0.0]: <https://github.com/stac-utils/stac-fastapi/tree/1.0.0>
[1.0.0]: <https://github.com/stac-utils/stac-fastapi/tree/1.0.0>
2 changes: 1 addition & 1 deletion stac_fastapi/sqlalchemy/tests/clients/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,4 +269,4 @@ class MockStarletteRequestWithApp(MockStarletteRequest):
landing_page = postgres_core.landing_page(request=MockStarletteRequestWithApp)
for link in landing_page["links"]:
if link["href"].split("/")[-1] == coll["id"]:
assert not link["title"]
assert link["title"]
2 changes: 1 addition & 1 deletion stac_fastapi/types/stac_fastapi/types/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def landing_page(self, **kwargs) -> stac_types.LandingPage:
{
"rel": Relations.child.value,
"type": MimeTypes.json.value,
"title": collection.get("title"),
"title": collection.get("title") or collection.get("id"),
"href": urljoin(base_url, f"collections/{collection['id']}"),
}
)
Expand Down