Include collection ID in ItemURI #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geospatial-jeff
approved these changes
Jun 8, 2021
|
This will be a breaking change because we are changing the signature of the base class. I'm fine with this because it's more explicit and it's better to forward all path parameters included in the request. |
Merged
bitner
added a commit
to bitner/stac-fastapi
that referenced
this pull request
Jun 14, 2021
geospatial-jeff
added a commit
that referenced
this pull request
Jun 18, 2021
* add .envrc to .*ignore * submodules all as one package * submodules all as one package * use namespace packages * remove setup.py from pgrest * update cicd workflow * cherry pick pgstac branch to updated package layout * allow async endpoints * core modifications needed for pgstac * cleanup * cleanup * setup console scripts * get transaction api working * bring in pgstac * remove old pgrest * bring Dockerfile over * cherrypicks * add removed readme back * linting, add gzip middleware * move mangum to awslambda extras * sorts * fixes for precommit * fixes for precommit * uggh pydocstyle * pgstac tests and fixes from tests * get test runners working * linting * tag for db compatible with pgstac * db docker uses different ENV vars * linted too hard * test cleanup * docker env fixes, documentation * docker env fixes, documentation * switch from gzip to brotli * Update stac_fastapi/api/stac_fastapi/api/app.py Co-authored-by: Kyle Barron <kylebarron2@gmail.com> * Update stac_fastapi/pgstac/setup.py Co-authored-by: Kyle Barron <kylebarron2@gmail.com> * Update stac_fastapi/pgstac/README.md Co-authored-by: Kyle Barron <kylebarron2@gmail.com> * fix issues in links for base_url and items relations type * fix docstring quotes * add item_id, collection_id in response to #138 * update pypgstac version * fix parent link * change id key to items_id in delete_item * update version of pgstac * Update docker-compose.yml call pgstac app as python module rather than using the cli command Co-authored-by: Jeff Albrecht <jeff@arturo.ai> * Update stac_fastapi/pgstac/README.md Co-authored-by: Jeff Albrecht <jeff@arturo.ai> * Update stac_fastapi/pgstac/stac_fastapi/pgstac/models/links.py Co-authored-by: Jeff Albrecht <jeff@arturo.ai> * Update stac_fastapi/pgstac/tests/clients/test_postgres.py Co-authored-by: Jeff Albrecht <jeff@arturo.ai> * Update stac_fastapi/pgstac/tests/clients/test_postgres.py Co-authored-by: Jeff Albrecht <jeff@arturo.ai> * Apply suggestions from code review remove unused load_test_data fixtures Co-authored-by: Jeff Albrecht <jeff@arturo.ai> * fixes from code review. remove unused/debug logging. remove unused functions. add type hints. * add import for asyncpg.pool for type hint * add default for initial pool and connection value * use request.json() because we are adding in the paging token to the POST request * linting fixes * make docker-compose use reload=false for uvicorn to avoid any issues with venvs * increase number of connections on pg instance, only mount scripts and stac_fastapi directories * move test data and add test data to both pgstac and sqlalchemy in docker, make no collections return empty array * fix test for collections returning empty array rather than not found * add exclude_unset=True when dumping data to json to add in transactions extension Co-authored-by: Kyle Barron <kylebarron2@gmail.com> Co-authored-by: Jeff Albrecht <jeff@arturo.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures all URL parameters provided to get a STAC item are available for implementing
get_itemmethods. Previously, only the item id was available.Closes #135