-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add free-text search extension #162
Conversation
e5393c3
to
5f67ec9
Compare
Now that pgstac 0.9.2 is released (with support for the |
@hrodmn should we then remove it from the if we keep it, could you add some tests for it? 🙏 |
Yes, I think removing it from the list of item search extensions by default is the way to go. Users could add it in custom applications if it would be helpful. It's all supported in Update: Actually free-text for item search is not really supported because |
Related Issue(s):
Description:
This is a pretty simple addition but it is dependent on the next release of pgstac (the pgstac-side changes were added in stac-utils/pgstac#295) so the new test will fail until we decide how to conditionally activate this feature. Would it make sense to only activate this extension if the
pgstac
version is >0.9.1?The
q
parameter should probably never be used in an item search because it will probably slow things down a lot, but it is very useful for the collection search function.PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)