Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test error occasionally #290

Closed
jonhealy1 opened this issue Aug 22, 2024 · 3 comments
Closed

Test error occasionally #290

jonhealy1 opened this issue Aug 22, 2024 · 3 comments

Comments

@jonhealy1
Copy link
Collaborator

This test seems to fail occasionally - maybe 5% of the time:

=========================== short test summary info ============================
FAILED stac_fastapi/tests/extensions/test_aggregation.py::test_post_aggregate_total_count - assert 2 == 1
@jamesfisher-geo jamesfisher-geo mentioned this issue Nov 23, 2024
Closed
4 tasks
@jamesfisher-geo
Copy link
Collaborator

I am not able to reproduce the error locally, but I have also noticed the issue when testing is run on github. My best guess is that it is an issue with async tests running in parallel.

@jamesfisher-geo jamesfisher-geo mentioned this issue Nov 24, 2024
Merged
4 tasks
jonhealy1 pushed a commit that referenced this issue Nov 30, 2024
@jamesfisher-geo
Aggregation Bugfix and Documentation Update (#314)
5ab4c4b 
**Related Issue(s):**

- #290

**Description:**

Includes a bugfix for Elasticsearch aggregation, the indices() function
was only checking if the input was None. But in POST requests the input
is an empty list ({}). So that was leading to some aggregations to
search through all indices in an Elasticsearch cluster, not just the
items indices.

**PR Checklist:**

- [x] Code is formatted and linted (run `pre-commit run --all-files`)
- [x] Tests pass (run `make test`)
- [x] Documentation has been updated to reflect changes, if applicable
- [x] Changes are added to the changelog
@jonhealy1
Copy link
Collaborator Author

I think we can close this now?

@jamesfisher-geo
Copy link
Collaborator

Yup. Fixed in #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up aggregation tests stac-utils/stac-fastapi-elasticsearch-opensearch
2 participants
@jonhealy1 @jamesfisher-geo