-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test, bench, and doc requirements out of pyproject.toml #1407
Conversation
This makes them easier to: - Freeze (using `uv pip compile`) - Avoid building in the case where all optional dependencies are enabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 91.20% 91.20%
=======================================
Files 52 52
Lines 7239 7239
Branches 1019 1019
=======================================
Hits 6602 6602
Misses 457 457
Partials 180 180 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Just one typo 😝
Just wondering: are you thinking that we should move away from the scripts to rule them all model?
Co-authored-by: Julia Signell <jsignell@gmail.com>
I personally don't love "scripts to rule them all" for libraries, I find they increase maintenance burden without much benefit. I think they're more useful for applications, when you have more resources to manage during development. E.g. when I see |
Description:
I've had some discussion with folks (cc @jkeifer) that have pointed me in the direction of not including development dependencies as
optional-dependencies
. This PR movestest
andbench
out to arequirements-dev.txt
, and thedoc
dependencies todocs/requirements.txt
.This will make it easier to:
uv pip compile
uv pip install --all-extras
PR Checklist:
pre-commit
hooks pass locallyscripts/test
)