Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for retry attribute #1358

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Documentation for retry attribute #1358

merged 3 commits into from
Jul 16, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jul 1, 2024

Related Issue(s):

Description:

Tweak to the documentation of the retry attribute of RetryStacIO. Doesn't need a changelog.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.

@gadomski gadomski changed the title ocumentation for retry attribute Documentation for retry attribute Jul 1, 2024
@gadomski gadomski self-assigned this Jul 1, 2024
@gadomski gadomski mentioned this pull request Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (346ff74) to head (6ef3ab9).
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          51       51           
  Lines        7070     7070           
  Branches     1012     1012           
=======================================
  Hits         6439     6439           
  Misses        451      451           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski requested a review from jsignell July 8, 2024 19:26
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know you could write docs like that!

@jsignell jsignell enabled auto-merge July 16, 2024 14:30
@jsignell jsignell added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit d9b354d Jul 16, 2024
24 checks passed
@jsignell jsignell deleted the issues/1353-retry-stac-io branch July 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants