Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and advertise python 3.12 #1260

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Test and advertise python 3.12 #1260

merged 3 commits into from
Mar 1, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 12, 2023 •
edited
Loading

Description:

Test against Python 3.12 in CI and advertise it in our package metadata.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.
  • (once approved) Add 3.12 to the required branch checks

@gadomski gadomski added this to the 1.9 milestone Oct 12, 2023
@gadomski gadomski requested a review from jsignell October 12, 2023 19:46
@gadomski gadomski self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (eb6566a) to head (5254422).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          51       51           
  Lines        7023     7023           
  Branches     1005     1005           
=======================================
  Hits         6404     6404           
  Misses        444      444           
  Partials      175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski removed the request for review from jsignell October 12, 2023 19:51
@gadomski gadomski marked this pull request as draft October 12, 2023 19:51
@gadomski
Copy link
Member Author

Converting to draft while we wait for upstreams to fix deprecation warnings.

@gadomski gadomski removed this from the 1.9 milestone Oct 13, 2023
@jsignell
Copy link
Member

jsignell commented Dec 1, 2023

Looks like dateutil/dateutil#1300 might be the only missing piece?

@gadomski gadomski requested a review from jsignell March 1, 2024 17:20
@gadomski gadomski marked this pull request as ready for review March 1, 2024 17:20
jsignell
jsignell approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@gadomski gadomski added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit b3edc53 Mar 1, 2024
24 checks passed
@gadomski gadomski deleted the python-3.12 branch March 1, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @jsignell