Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to STAC_URL environment variable when opening a Client #48

Merged
merged 4 commits into from
May 5, 2021
Merged

Fall back to STAC_URL environment variable when opening a Client #48

merged 4 commits into from
May 5, 2021

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 3, 2021

Related Issue(s): #47

Description: Fall back to an environment variable when opening a client. Includes a unit test.

Sidecar:

  • Ensures that the from_file monkeypatch is rolled back in case of an exception.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #48 (7e0aaf8) into main (77d95a2) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   85.09%   85.23%   +0.14%     
==========================================
  Files          13       13              
  Lines         624      630       +6     
==========================================
+ Hits          531      537       +6     
  Misses         93       93              
Impacted Files Coverage Δ
pystac_client/client.py 98.57% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d95a2...7e0aaf8. Read the comment docs.

@matthewhanson matthewhanson merged commit ee54486 into stac-utils:main May 5, 2021
@gadomski gadomski deleted the feature/47-stac-url-environ branch May 5, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants