style(card review modal): reorder stats containers #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that is a very valid argument. I just wanted that the colors are in the order of the hard, good and easy buttons, so it is a bit more uniform. If I just switched the colors, then the association of the user, which color represents what would maybe confuse some users. But I am fine with them switching back, if you choose function over form here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up on #899
I think that we should show the "most useful" counts first. When reviewing, it's best if users see the due & new cards first as this makes it a bit easier to select the deck to review especially for left-to-right languages which are the vast majority of what we support. Or if they have many decks.
@KyleKlus