Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for atomic clozures #731

Closed
wants to merge 0 commits into from
Closed

Conversation

Stefanuk12
Copy link

@Stefanuk12 Stefanuk12 commented Aug 22, 2023

Addresses

#730, #450

@Stefanuk12
Copy link
Author

Stefanuk12 commented Aug 23, 2023

Some test cases do fail, not sure why...

  • Testing parsing of clozure cards
  • Testing parsing of a mix of card types

Will try to fix...

PR vs Original

It seems like my PR causes different behaviour - which I partially intended. I expected the text after the clozure to not count, which it did not. However, it also counted text before which I did not want. Possibly a new clozure type could be introduced to only count singular lines and one that has the original multi-line behaviour.

The reason I want this included is because imagine you have the following note:

# Uncertainty

- There is ==always== uncertainty some when taking measurements
- The uncertainty is a measure of ==the difference between actual reading and true value==
- Uncertainties are not an error, but ==estimates==.

You would want each bullet point to have its own flashcard. In order for the plugin to count it as separate flashcards, you must add new lines between each bullet which makes it look ugly.

PR

many text
such surprise [...] more text
some text before
a deletion on
such [...]

Original

many text
such surprise [...] more text
some text after
some text before
a deletion on
such [...]

Desired

such surprise [...] more text
such [...]

Addresses

#450

@Stefanuk12
Copy link
Author

I've implemented my idea. Not able to get the translations of course but I also modified the tests and such. By default, the original behaviour is seen.

@Stefanuk12 Stefanuk12 changed the title A possible fix for #730 A possible fix for #730 and #486 Aug 25, 2023
@Stefanuk12 Stefanuk12 changed the title A possible fix for #730 and #486 A possible fix for #730 and #450 Aug 25, 2023
@Stefanuk12 Stefanuk12 changed the title A possible fix for #730 and #450 Support for atomic clozures Aug 25, 2023
@Stefanuk12
Copy link
Author

This could be expanded on and allowing control of this behaviour per flashcard instead of a global setting. I'm not sure the best way of doing this so I did not include it.

@Stefanuk12
Copy link
Author

There's currently a bug where the scheduling data is not included within the card text. I need to add a look ahead for that.

@PaperOrb
Copy link

Can't wait for this to be merged because adding a newline before and after every piece of text that I want converted into a card is ugly and tiresome.

@PaperOrb
Copy link

PaperOrb commented Oct 16, 2023

@Stefanuk12 Does the force-push mean that this was added to the main repository?

@Stefanuk12
Copy link
Author

@Stefanuk12 Does the force-push mean that this was added to the main repository?

Nope, I'll close this PR - I forgot to. The new update broke a lot of things so I'll need to work on alternative: implementing anki-type cards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants