-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for atomic clozures #731
Conversation
Some test cases do fail, not sure why...
Will try to fix... PR vs OriginalIt seems like my PR causes different behaviour - which I partially intended. I expected the text after the clozure to not count, which it did not. However, it also counted text before which I did not want. Possibly a new clozure type could be introduced to only count singular lines and one that has the original multi-line behaviour. The reason I want this included is because imagine you have the following note: # Uncertainty
- There is ==always== uncertainty some when taking measurements
- The uncertainty is a measure of ==the difference between actual reading and true value==
- Uncertainties are not an error, but ==estimates==.
You would want each bullet point to have its own flashcard. In order for the plugin to count it as separate flashcards, you must add new lines between each bullet which makes it look ugly. PR
Original
Desired
Addresses |
I've implemented my idea. Not able to get the translations of course but I also modified the tests and such. By default, the original behaviour is seen. |
This could be expanded on and allowing control of this behaviour per flashcard instead of a global setting. I'm not sure the best way of doing this so I did not include it. |
There's currently a bug where the scheduling data is not included within the card text. I need to add a look ahead for that. |
Can't wait for this to be merged because adding a newline before and after every piece of text that I want converted into a card is ugly and tiresome. |
@Stefanuk12 Does the force-push mean that this was added to the main repository? |
Nope, I'll close this PR - I forgot to. The new update broke a lot of things so I'll need to work on alternative: implementing anki-type cards |
Addresses
#730, #450