Make reset button (flashcard review modal) enabled for both new and due cards #650
Conversation
This allows putting the flashcard back temporarily while learning it. Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com> # Conflicts: # src/flashcard-modal.tsx
Signed-off-by: William So <polyipseity@gmail.com>
|
Done. |
|
Hi @polyipseity Thanks for this, I updated the PR title from "Make reset button always enabled" because the button isn't "always" enabled. It is still disabled whilst the question is shown, but always shown when the answer is. Cheers |
Dismissing Steven's review because I can't seem to approve it (after I've reviewed)
|
I was about to make a release and after testing the changes, it looks like a change in #873 reverted some of your changes (apologies for that). I've fixed that by reintroducing the missing changes (locally). It looks like the reset button now behaves the same way as skipping the new card 🤔. Am I missing something? I was thinking that it should put the new card at the back of the queue so that you can see it later. Sorta like a version of the Again button in Anki. Thoughts? |
|
Opened the draft PR here -> #902 |
|
Yes, it works as expected. Thanks for the heads up. |
This allows putting the flashcard back temporarily while learning it.
Currently I simply add
<!--SR:!<date of today>,1,250-->to my flashcards whenever I learn them to enable the reset button. It would be nice to have this ability builtin instead.