State comparison - SSV runner/consensus #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5138c0f to
75343f7
Compare
|
@GalRogozinski we should add generated json tests to this PR |
json looks fine |
GalRogozinski
approved these changes
Jun 11, 2023
alonmuroch
requested changes
Jun 11, 2023
| }, | ||
| { | ||
| Name: "sync committee", | ||
| Runner: testingutils.SyncCommitteeRunner(ks), | ||
| Duty: &testingutils.TestingSyncCommitteeDuty, | ||
| Messages: append( | ||
| testingutils.SSVDecidingMsgsV(testingutils.TestSyncCommitteeConsensusData, ks, types.BNRoleSyncCommittee), | ||
| // post consensus |
| OutputMessages: []*types.SignedPartialSignatureMessage{ | ||
| testingutils.PreConsensusSelectionProofMsg(ks.Shares[1], ks.Shares[1], 1, 1), | ||
| testingutils.PostConsensusAggregatorMsg(ks.Shares[1], 1), | ||
| }, | ||
| BeaconBroadcastedRoots: []string{ | ||
| testingutils.GetSSZRootNoError(testingutils.TestingSignedAggregateAndProof(ks)), |
There was a problem hiding this comment.
it prev did not broadcast it?
| }, | ||
| { | ||
| Name: "attester", | ||
| Runner: testingutils.AttesterRunner(ks), | ||
| Duty: &testingutils.TestingAttesterDuty, | ||
| Messages: append( | ||
| testingutils.SSVDecidingMsgsV(testingutils.TestAttesterConsensusData, ks, types.BNRoleAttester), | ||
| // post consensus | ||
| testingutils.SSVMsgAttester(nil, testingutils.PostConsensusAttestationMsg(ks.Shares[1], 1, qbft.FirstHeight)), |
alonmuroch
requested changes
Jun 14, 2023
y0sher
approved these changes
Jun 14, 2023
alonmuroch
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce state comparison for sanity SSV runner/consensus tests
closes #250
reference to sanity tests #162