Add support for TLS connections to tiller #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I just now saw this I need to enable email notifications again. I'll review it later this weekend. |
sstarcher
requested changes
May 11, 2019
main.go
Outdated
| tillerNamespace = flag.String("tiller-namespace", "kube-system", "namespace of Tiller (default \"kube-system\")") | ||
| tillerTLSEnable = flag.Bool("tiller-tls-enable", false, "enable TLS communication with tiller (default false)") | ||
| tillerTLSKey = flag.String("tiller-tls-key-path", "/etc/helm-exporter/tls.key", "path to private key file used to communicate with tiller") | ||
| tillerTLSCert = flag.String("tiller-tls-cert-path", "/etc/helm-exporter/tls.crt", "path to certificate key file used to communicate with tiller") |
There was a problem hiding this comment.
Lets use the same flags as tiller --tiller-tls-cert
main.go
Outdated
| tillerNamespace = flag.String("tiller-namespace", "kube-system", "namespace of Tiller (default \"kube-system\")") | ||
| tillerTLSEnable = flag.Bool("tiller-tls-enable", false, "enable TLS communication with tiller (default false)") | ||
| tillerTLSKey = flag.String("tiller-tls-key-path", "/etc/helm-exporter/tls.key", "path to private key file used to communicate with tiller") |
main.go
Outdated
| tlsopts := tlsutil.Options{ | ||
| KeyFile: *tillerTLSKey, | ||
| CertFile: *tillerTLSCert, | ||
| InsecureSkipVerify: true, |
There was a problem hiding this comment.
Lets add a flag for this --tiller-tls-verify
main.go
Outdated
| } | ||
| tlscfg, err := tlsutil.ClientConfig(tlsopts) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("unable to create TLS config: %s", err)) |
There was a problem hiding this comment.
return a err instead of panicing
|
Thanks for the review. I changed the code according to your feedback. |
sstarcher
approved these changes
May 13, 2019
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiller may be configured to only accept TLS connections from clients with a valid known certificate. This PR adds the possibility to specify and use a TLS client cert in helm-exporter to successfully connect to such tiller instances.
The helm-exporter can be configured with the newly added command line flags
tiller-tls-enable,tiller-tls-key-pathandtiller-tls-cert-path.