New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback #1

Open

dope791 wants to merge 1 commit into ssalehi:list-samples from dope791:list-samples

dope791 commented Nov 23, 2024

Hi Sareh,

here is my code comments for you!
You're welcome to ask if there arise any further questions.
So far really well done!

Feedback

Only use referenced elements (I don't remember being introduced to any libraries by Professor Lanese)
Don't mix "print()" and expressions (like "DNASeq.count('A')") too much -> store expressions in variables and reference them in "print()" -> it's not all about one-liners

Kind regards
Elena


          comments from Elena

4e65402

dope791 marked this pull request as ready for review

November 23, 2024 22:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet