Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] фикс пельменей, модульного сандэя и перепутанных спрайтов соусов #1795

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

Zondus
Copy link

@Zondus Zondus commented Feb 9, 2025

Что этот PR делает

Поправил модульную еду:

Исправлен путь к нарезанному тесту в пельменях и сандэе после(ParadiseSS13#28146), а так же поправил перепутанные спрайты дьябло соуса и томатного соуса

Почему это хорошо для игры

Снова можно лепить пельмени, а все соуса в своих соусниках(Как работник общепита скажу, что это немного бесит)

Изображения изменений

Тестирование

Слепил пельмени. Вкусно

Changelog

🆑
fix: Снова можно лепить пельмени и делать Сандэй
fix: Исправлены перепутанные иконки у Томатного и Дьябло соусов
/:cl:

Summary by Sourcery

Fix the dumpling and sundae recipes to use the correct sliced dough item. Also correct the Diablo and tomato sauce sprites.

Bug Fixes:

  • Fixed an issue that prevented players from crafting dumplings and sundaes.

Chores:

  • Fixed swapped sprites for Diablo and tomato sauces.

Copy link

sourcery-ai bot commented Feb 9, 2025

Reviewer's Guide by Sourcery

This PR addresses issues with modular food recipes by correcting an incorrect path reference for dough slicing in pelmeni and sundae items, and by swapping the mis-assigned sprites for Diablo and Tomato sauces to ensure they display correctly.

Updated class diagram for modular food recipes

classDiagram
    class FoodRecipes {
        +list items
        +result
    }

    class SlicedDough {
        +attackby__legacy__attackchain(obj/item/I, mob/user, params)
    }

    FoodRecipes --> SlicedDough : uses
    note for SlicedDough "Replaces old /obj/item/food/doughslice reference"

    class SauceSprites {
        +displayDiabloSprite()
        +displayTomatoSprite()
    }

    note for SauceSprites "Swapped sprites to correctly show Diablo and Tomato sauces"
Loading

File-Level Changes

Change Details Files
Fixed the incorrect path reference for dough slicing.
  • Replaced the '/obj/item/food/doughslice' reference with '/obj/item/food/sliced/dough' in the food item list.
  • Updated the attackby function to call the correct sliced dough object.
modular_ss220/food_and_drinks/code/food/food.dm
Corrected swapped sprites for Diablo and Tomato sauces.
  • Swapped the sprites so that Diablo sauce and Tomato sauce now appear in their correct sauce holders.
modular_ss220/food_and_drinks/code/food/food.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! label Feb 9, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Feb 9, 2025
@m-dzianishchyts m-dzianishchyts merged commit f65d82c into ss220club:master Feb 9, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! 📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants