Update deps, plugins #91
Merged
+20
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
commented
Dec 13, 2016
| @@ -11,7 +11,7 @@ import java.time.LocalDate | |||
| import java.time.format.DateTimeFormatter | |||
|
|
|||
| import scala.collection.mutable.ArrayBuffer | |||
| import org.apache.spark.mllib.stat.KernelDensity | |||
| import org.apache.spark.mllib.stat.{KernelDensity => SparkKernelDensity} | |||
| </dependency> | ||
| <!-- This is only here for edu.umd:cloud9 which depends on non-existent 3.0.16 --> | ||
| <dependency> | ||
| <groupId>info.bliki.wiki</groupId> |
There was a problem hiding this comment.
Also CC @sryza -- worth trying updating several of these dependencies? I don't see a reason to suspect it'll break, and it compiles, but haven't tried it.
There was a problem hiding this comment.
@srowen I don't have strong feelings either way, but what's the advantage? Given that the code is working with the existing versions, it could only break things.
There was a problem hiding this comment.
Just potential bug fixes and tidiness. It seemed worth trying out while we're re-running this code frequently anyway. It is not essential as far as I can tell. The breeze update is worthwhile to match Spark; the plugin updates should be no problem. The rest can be easily backed out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.