Some suggested changes to style #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
commented
Dec 1, 2016
| @@ -155,7 +155,7 @@ class LSAQueryEngine( | |||
| val newMat = new BDenseMatrix[Double](mat.rows, mat.cols) | |||
| for (r <- 0 until mat.rows) { | |||
| val length = math.sqrt((0 until mat.cols).map(c => mat(r, c) * mat(r, c)).sum) | |||
| (0 until mat.cols).map(c => newMat.update(r, c, mat(r, c) / length)) | |||
| (0 until mat.cols).foreach(c => newMat.update(r, c, mat(r, c) / length)) | |||
There was a problem hiding this comment.
CC @sryza -- think this might happen to work but should be foreach. Giving a heads up in case it needs to be reflected in text too.
| @@ -50,7 +50,7 @@ object RunGeoTime extends Serializable { | |||
| } | |||
| val hoursUDF = udf(hours) | |||
|
|
|||
| taxiGood.groupBy(hoursUDF('pickupTime, 'dropoffTime)).count().show() | |||
| taxiGood.groupBy(hoursUDF($"pickupTime", $"dropoffTime")).count().show() | |||
There was a problem hiding this comment.
@jwills Spark SQL has (at least) 3 ways to refer to columns. I had used $"..." syntax elsewhere instead of '.... I think it's the same. Is it OK to use $? CCing you in case it needs a text change to go along with it.
There was a problem hiding this comment.
Totally fine, and thanks for the heads up!
| @@ -106,6 +104,6 @@ object KernelDensity { | |||
| x: Double): Double = { | |||
| val x0 = x - mean | |||
| val x1 = x0 / standardDeviation | |||
| FastMath.exp(-0.5 * x1 * x1 - logStandardDeviationPlusHalfLog2Pi) | |||
| math.exp(-0.5 * x1 * x1 - logStandardDeviationPlusHalfLog2Pi) | |||
There was a problem hiding this comment.
(DIdn't seem like a good reason to use FastMath in just a few places here FWIW)
|
@srowen these seem reasonable to me. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.