Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opt module #22

Merged
merged 1 commit into from
Sep 16, 2021
Merged

fix: opt module #22

merged 1 commit into from
Sep 16, 2021

Conversation

khorevaa
Copy link
Contributor

When use -go_out=. --go_opt=module=github.com/khorevaa/awesomeProject2 files not found

Add read option module for --gotag_opt=module=github.com/khorevaa/awesomeProject2 and trim prefix from filename

@srikrsna
Copy link
Owner

srikrsna commented Sep 5, 2021

Hi thank you for the PR. Let me check and get back to you. My understanding was that protoc-gen-star takes care of this nuances. But I guess not!

@alexandrevilain
Copy link

alexandrevilain commented Sep 15, 2021

Hi @srikrsna :)

I can confirm that @khorevaa's PR fixes the opt module. I had the issue using the module option.
@khorevaa's fix makes it work as expected.

@srikrsna srikrsna merged commit 329b36e into srikrsna:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants