Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when call the ZipFile.removefile method have some problems about building zipmodel for remove #315

Closed
yuki-naki opened this issue May 2, 2021 · 2 comments
Closed

when call the ZipFile.removefile method have some problems about building zipmodel for remove #315

yuki-naki opened this issue May 2, 2021 · 2 comments
Assignees
@srikanth-lingala
Labels
bug Something isn't working resolved

Comments

@yuki-naki
Copy link

a.zip inside have two file
a.js
a.json

when try remove file (a.js)

ZipFile zip = new ZipFile("a,zip");
zip.removeFile("a.js");

will remove a.js and a.json together
@yuki-naki yuki-naki changed the title call the zip.removeFiles method when building zipmodel have some problems call the ZipFile.removeFiles method when building zipmodel have some problems May 2, 2021
@yuki-naki yuki-naki changed the title call the ZipFile.removeFiles method when building zipmodel have some problems when call the ZipFile.removefile method have some problems about building zipmodel for remove May 2, 2021
@srikanth-lingala
Copy link
Owner

Thanks for reporting this issue. I was able to reproduce it. I will include a fix in the next release.

@srikanth-lingala srikanth-lingala self-assigned this May 2, 2021
@srikanth-lingala srikanth-lingala added bug Something isn't working in-progress labels May 2, 2021
srikanth-lingala added a commit that referenced this issue May 3, 2021
@srikanth-lingala
#315 Use equals when comparing for file names in entry deletion
76a4ba5
srikanth-lingala added a commit that referenced this issue May 3, 2021
@srikanth-lingala
#315 Fix entry removal logic check
cd37bb5
srikanth-lingala added a commit that referenced this issue May 23, 2021
@srikanth-lingala
#315 Flip file name directory check
f31f930
@srikanth-lingala
Copy link
Owner

Fixed in v2.8.0 released today.

@srikanth-lingala srikanth-lingala mentioned this issue Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-lingala srikanth-lingala

Labels
bug Something isn't working resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srikanth-lingala @yuki-naki