Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention JRE requirement more prominently in README #212

Closed
Marcono1234 opened this issue Jul 4, 2020 · 6 comments
Closed

Mention JRE requirement more prominently in README #212

Marcono1234 opened this issue Jul 4, 2020 · 6 comments

Comments

@Marcono1234
Copy link
Contributor

Point 5 of the FAQ mentions in a side note that this project requires at least Java 8.
This requirement is probably rather important for many users of the library and it would be good if this could be mentioned somewhere at the beginning of the README. Though I am not sure which one of the existing sections would fit, so maybe adding a new "Requirements" section would be good?

@srikanth-lingala
Copy link
Owner

Sure, and actually this point needs to be updated as zip4j supports Java 7 as well. When rewriting zip4j, the minimum version of JDK supported was 8, but based on requests by android app developers, I had to rewrite some parts to supports Java 7 as well to support older Android SDKs.

@Marcono1234
Copy link
Contributor Author

Should I write a pull request, or do you want to perform this change?

@srikanth-lingala
Copy link
Owner

I added it to a newly created section Requirements in README.

@Marcono1234
Copy link
Contributor Author

Marcono1234 commented Jul 31, 2020

Thanks. I have left some comments on the commit describing how it could possible be slightly improved.
Feel free to close this issue now.

@Marcono1234
Copy link
Contributor Author

@srikanth-lingala, have you seen my comments on your commit 1bbb90c?

@srikanth-lingala
Copy link
Owner

Actually, I just had a look at them. And they are now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants