Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zipping symlinks that point to non-existent files #195

Closed
srikanth-lingala opened this issue May 27, 2020 · 2 comments
Closed

Support zipping symlinks that point to non-existent files #195

srikanth-lingala opened this issue May 27, 2020 · 2 comments
Assignees
@srikanth-lingala
Labels
bug Something isn't working resolved

Comments

@srikanth-lingala
Copy link
Owner

Created out of PR #193

I ran into an issue where zip4j threw an Exception trying to zip a directory that had a symlink to a file that didn't exist. Since I don't control the directory contents (it's a vendored dependency) I was hoping you'd accept this patch that adds the broken symlink as is to the zip if you specify ZipParameters.SymbolicLinkAction.INCLUDE_LINK_ONLY.
@srikanth-lingala srikanth-lingala self-assigned this May 27, 2020
srikanth-lingala added a commit that referenced this issue May 27, 2020
@srikanth-lingala
#195 Support zipping symlinks that point to non-existent files
0eb7e86
srikanth-lingala added a commit that referenced this issue May 27, 2020
@srikanth-lingala
#195 Fix failing tests
5a3233b
srikanth-lingala added a commit that referenced this issue May 27, 2020
@srikanth-lingala
#195 Fix failing tests
089bd6e
@srikanth-lingala srikanth-lingala mentioned this issue May 27, 2020
Closed
@srikanth-lingala
Copy link
Owner Author

Issue fixed. Will include the fix in the next release.

@srikanth-lingala srikanth-lingala added resolved bug Something isn't working and removed in-progress improvement labels May 27, 2020
@srikanth-lingala
Copy link
Owner Author

Fix included in v2.6.1 released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-lingala srikanth-lingala

Labels
bug Something isn't working resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srikanth-lingala