Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SQL logic, Library changes #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: SQL logic, Library changes #23

wants to merge 4 commits into from

Conversation

Rushaway
Copy link
Member

No description provided.

@Rushaway Rushaway changed the title fix: small optimisations for Library Changes fix: SQL logic, Library changes Jan 26, 2025
@Rushaway
Copy link
Member Author

Rushaway commented Jan 26, 2025 •
edited
Loading

The SQL part is un-tested yet.

  • Replace the usage of SQL_Connect with SQL_TConnect
  • Connects to a database via a thread for using a non-blocking functionality.
  • DB Lost / Retry logic

@maxime1907
Copy link
Member

logic seems ok, need to test on main server for a week

@Rushaway
Copy link
Member Author

Thiese recent changes fix an issue where a database handle become null.
In a next PR we will maybe can merge all DB functions and use enum to make things cleanner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime1907 maxime1907 maxime1907 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rushaway @maxime1907