Skip to content
This repository has been archived by the owner on May 22, 2019. It is now read-only.

Fix docker image #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix docker image #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Cython>=0.28,<1.0; python_version == '3.7'
PyStemmer==1.3.0
bblfsh==2.12.7
bblfsh==2.9.13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zurk I think that setting the version to 2.9.13 will break the downstream packages which require a newer version... Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best option I see is to ask data retrieval team to update bblfsh requirement and publish the new package. The problem is sourced-jgit-spark-connector is deprecated...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not going to be updated, also there may be a backward incompatibility. Besides, we will soon have to switch to v3. I think that we should accept this change and work around it in dependent projects.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree.

modelforge==0.11.1
sourced-jgit-spark-connector==2.0.1
parquet==1.2
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@
"scikit-learn>=0.19,<1.0",
"tqdm>=4.20,<5.0",
"typing;python_version<'3.5'",
"pandas<0.21",
],
extras_require={
"tf": ["tensorflow>=1.0,<2.0"],
"tf_gpu": ["tensorflow-gpu>=1.0,<2.0"],
"pandas": ["pandas>=0.24.1,<1.0"],
},
tests_require=["docker>=3.6.0,<4.0"],
package_data={"": ["LICENSE.md", "README.md"],
Expand Down