This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql: implement LEFT and RIGHT join #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4f5750 to
31de7bb
Compare
|
CI fails because of C# integration test |
ajnavarro
approved these changes
May 20, 2019
juanjux
approved these changes
May 23, 2019
|
could you rebase please? |
31de7bb to
1158b47
Compare
|
Rebased |
Closes src-d#707 This PR implements LEFT and RIGHT join. Initial issue only required LEFT join, but the effort to also add support to RIGHT join was minimal, so it was added as well. The join iterator, previously inner join iterator, has been generalized so it can work for all joins and share all the logic in a single component instead of having three iterators handling the complex logic of how to compute the joins (in memory, multipass, etc). The nodes, however, have very subtle differences that make it worthless to abstract because most methods need to be different. The only abstractable part was the RowIter method, which was extracted to a function that's called from InnerJoin, LeftJoin and RightJoin nodes. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #707
This PR implements LEFT and RIGHT join. Initial issue only required
LEFT join, but the effort to also add support to RIGHT join was
minimal, so it was added as well.
The join iterator, previously inner join iterator, has been generalized
so it can work for all joins and share all the logic in a single
component instead of having three iterators handling the complex logic
of how to compute the joins (in memory, multipass, etc).
The nodes, however, have very subtle differences that make it worthless
to abstract because most methods need to be different. The only abstractable
part was the RowIter method, which was extracted to a function that's
called from InnerJoin, LeftJoin and RightJoin nodes.
Signed-off-by: Miguel Molina miguel@erizocosmi.co