Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

server: correctly set binary charset on blob fields #673

Merged
merged 1 commit into from
Apr 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions server/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,11 +221,9 @@ func rowToSQL(s sql.Schema, row sql.Row) []sqltypes.Value {
func schemaToFields(s sql.Schema) []*query.Field {
fields := make([]*query.Field, len(s))
for i, c := range s {
var charset uint32
if c.Type.Type() == mysql.TypeBlob {
var charset uint32 = mysql.CharacterSetUtf8
if c.Type == sql.Blob {
charset = mysql.CharacterSetBinary
} else {
charset = mysql.CharacterSetUtf8
}

fields[i] = &query.Field{
Expand Down
20 changes: 20 additions & 0 deletions server/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"gopkg.in/src-d/go-mysql-server.v0/sql"
"gopkg.in/src-d/go-vitess.v1/mysql"
"gopkg.in/src-d/go-vitess.v1/sqltypes"
"gopkg.in/src-d/go-vitess.v1/vt/proto/query"

opentracing "github.com/opentracing/opentracing-go"
"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -223,3 +224,22 @@ func assertNoConnProcesses(t *testing.T, e *sqle.Engine, conn uint32) {
}
}
}

func TestSchemaToFields(t *testing.T) {
require := require.New(t)

schema := sql.Schema{
{Name: "foo", Type: sql.Blob},
{Name: "bar", Type: sql.Text},
{Name: "baz", Type: sql.Int64},
}

expected := []*query.Field{
{Name: "foo", Type: query.Type_BLOB, Charset: mysql.CharacterSetBinary},
{Name: "bar", Type: query.Type_TEXT, Charset: mysql.CharacterSetUtf8},
{Name: "baz", Type: query.Type_INT64, Charset: mysql.CharacterSetUtf8},
}

fields := schemaToFields(schema)
require.Equal(expected, fields)
}