This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql/analyzer: add rule to avoid unnecessary casts #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarmonaa
reviewed
Nov 2, 2018
sql/analyzer/rules.go
Outdated
| @@ -20,6 +20,7 @@ var DefaultRules = []Rule{ | |||
| {"move_join_conds_to_filter", moveJoinConditionsToFilter}, | |||
| {"eval_filter", evalFilter}, | |||
| {"optimize_distinct", optimizeDistinct}, | |||
| {"remove_unnecessary_converts", removeUnnecessaryConverts}, | |||
There was a problem hiding this comment.
What do you think about moving this rule to OnceAfterDefault? Is it necessary run it several times?
There was a problem hiding this comment.
@mcarmonaa It should be executed several times because the plan will change and could contain new unnecessary casts again.
jfontan
approved these changes
Nov 2, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
f169c5c to
d7e7d21
Compare
ajnavarro
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502