This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Fix substring/2 #421
Merged
Fix substring/2 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kuba-- Could you add some more tests to |
erizocosmico
approved these changes
Oct 8, 2018
mcarmonaa
approved these changes
Oct 8, 2018
Signed-off-by: kuba-- <kuba@sourced.tech>
|
@smola, @ajnavarro - I've added a test with negative index, but neither |
smola
approved these changes
Oct 9, 2018
|
@kuba-- Ok. I don't think it's very important, but wanted to verify if it worked correctly with the currently supported syntax. If it's a low hanging fruit, it makes sense to file a PR to vitess. |
|
@smola - ok, I'll take a look on this in a spare time (maybe OSD). |
ajnavarro
approved these changes
Oct 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
Closes: #418