seq #33
Merged
seq #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfbcee3 to
27e064d
Compare
lilactown
commented
Aug 17, 2022
| throw new Error( | ||
| "Illegal argument: assoc expects an odd number of arguments." | ||
| ); | ||
| throw new Error('Illegal argument: assoc expects an odd number of arguments.'); |
There was a problem hiding this comment.
some of these changes come from prettier reformatting. sorry for the noise. I hope it matches the style intended
lilactown
commented
Aug 17, 2022
Comment on lines
-222
to
+220
| return x instanceof String || Symbol.iterator in x; | ||
| return typeof x === 'string' || x === null || x === undefined || Symbol.iterator in x; |
There was a problem hiding this comment.
apparently this was totally broken for strings before
|
I think this is ready for review |
borkdude
added a commit
that referenced
this pull request
Dec 24, 2022
borkdude
added a commit
that referenced
this pull request
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer the following questions and leave the below in as part of your PR.
Related #22
This PR implements the following:
iterable?toseqable?and adds support fornilandjs/undefinediterableto return an empty array whennilorundefinedare passedseqfunction which is just likeiterablebut returnsnilwhen the iterable is empty.first,secondandrestto calliterablebefore destructuring.seqThis now allows us to do things like the following: