Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 5311: clarify configuration byte units #1979

Closed
wants to merge 3 commits into from
Closed

Bug 5311: clarify configuration byte units #1979

wants to merge 3 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Jan 8, 2025

No description provided.

@kinkie kinkie added the backport-to-v6 maintainer has approved these changes for v6 backporting label Jan 8, 2025
rousskov
rousskov requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this clarification (with small adjustments).

src/cf.data.pre Outdated Show resolved Hide resolved
src/cf.data.pre Outdated Show resolved Hide resolved
kinkie and others added 2 commits January 9, 2025 14:58
@kinkie @rousskov
Update src/cf.data.pre
2a726d3 
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
@kinkie @rousskov
Update src/cf.data.pre
751bfee 
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
@kinkie kinkie requested a review from rousskov January 9, 2025 15:02
@kinkie kinkie added the S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box label Jan 9, 2025
@rousskov rousskov added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Jan 9, 2025
squid-anubis pushed a commit that referenced this pull request Jan 10, 2025
@kinkie @squid-anubis
Bug 5311: clarify configuration byte units (#1979)
5fa48bb
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Jan 10, 2025
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Jan 10, 2025
squidadm pushed a commit to squidadm/squid that referenced this pull request Jan 19, 2025
@kinkie @squidadm
Bug 5311: clarify configuration byte units (squid-cache#1979)
debeceb
@squidadm squidadm removed the backport-to-v6 maintainer has approved these changes for v6 backporting label Jan 19, 2025
@squidadm
Copy link
Collaborator

queued for backport to v6

kinkie added a commit that referenced this pull request Jan 19, 2025
@kinkie
Bug 5311: clarify configuration byte units (#1979)
14e7c46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinkie @squidadm @rousskov @squid-anubis