Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow URL to be provided as region #42

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Allow URL to be provided as region #42

merged 3 commits into from
Apr 8, 2024

Conversation

shaswot77
Copy link
Contributor

Description

  • Allowing url as region will help us to connect with our other accounts as well as this will allow us to provide stage overrides as well
  • Added a check that will validate if the api key is valid with the provided region.

Checklist:

  • Added a label: bug-fix, feature, or enhancement
  • PR description written

@shaswot77 shaswot77 added the enhancement New feature or request label Apr 2, 2024
P2P-Nathan
P2P-Nathan approved these changes Apr 2, 2024
View reviewed changes
Copy link

@P2P-Nathan P2P-Nathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a thought on catching or documenting a trailing slash, but nothing critical.

internal/provider/client.go Show resolved Hide resolved
@shaswot77 shaswot77 merged commit 1d8955f into main Apr 8, 2024
6 checks passed
@shaswot77 shaswot77 deleted the work/ss/allow-url-as-region branch April 8, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P2P-Nathan P2P-Nathan P2P-Nathan approved these changes

@wigsaparelli wigsaparelli wigsaparelli approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaswot77 @P2P-Nathan @wigsaparelli