Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace Resource Tidyup #31

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Workspace Resource Tidyup #31

merged 5 commits into from
Jan 31, 2024

Conversation

shaswot77
Copy link
Contributor

@shaswot77 shaswot77 commented Jan 31, 2024 •
edited
Loading

Description

  • Changed open_access_enabled to allow_dashboard_sharing
  • Cleaned up some of the properties of struct that we do not use and are not needed to be exposed
  • Refactored workspace resource as I now have more understanding of Golang

Checklist:

  • Added a label: bug-fix, feature, or enhancement
  • PR description written

Test:

Breaking Change:
image

A quick replace all on the .tf files for open_access_enabled to allow_dashboard_sharing fixes the issue

@shaswot77 shaswot77 added the enhancement New feature or request label Jan 31, 2024
@shaswot77 shaswot77 changed the title Workspace Resource Workspace Resource Tidyup Jan 31, 2024
@shaswot77 shaswot77 merged commit d2bb674 into main Jan 31, 2024
6 checks passed
@shaswot77 shaswot77 deleted the work/ss/cleanup branch January 31, 2024 16:25
@shaswot77 shaswot77 mentioned this pull request Feb 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkd clarkd clarkd approved these changes

@wigsaparelli wigsaparelli wigsaparelli approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaswot77 @clarkd @wigsaparelli