Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Dashboard Sharing #26

Merged
merged 11 commits into from
Jan 22, 2024
Merged

Support for Dashboard Sharing #26

merged 11 commits into from
Jan 22, 2024

Conversation

shaswot77
Copy link
Contributor

Description

Added a new squaredup_dashboard_share resource which will allow to enable OA for Dashboards

We already support enabling Open Access for workspace resource. Next will be to allow enabling OA at tenant level.

Checklist:

  • Added a label: bug-fix, feature, or enhancement
  • PR description written

@shaswot77 shaswot77 added the feature New Feature label Jan 17, 2024
@wigsaparelli
Copy link

A general comment:
I think we should avoid using "open access" / "openaccess" etc. anywhere, we don't need to (fine for api endpoints as required) and use shares / sharing / shared dashboard(s). Our user interface never uses the term open access, you only see it in the address bar if you happen to inspect it. The UI always refers to sharing / shares / shared dashboard(s) and I think we should stick to the same nomenclature in Terraform.

@shaswot77
Copy link
Contributor Author

A general comment: I think we should avoid using "open access" / "openaccess" etc. anywhere, we don't need to (fine for api endpoints as required) and use shares / sharing / shared dashboard(s). Our user interface never uses the term open access, you only see it in the address bar if you happen to inspect it. The UI always refers to sharing / shares / shared dashboard(s) and I think we should stick to the same nomenclature in Terraform.

Good Point! I have renamed all open access to shared dashboard.

wigsaparelli
wigsaparelli reviewed Jan 19, 2024
View reviewed changes
docs/resources/dashboard_share.md
- `id` (String) The ID of the Shared dashboard
- `last_updated` (String) The last time the Dashboard Share was updated

## Import
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this import section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import allows you to import resources that were not created through terraform to its configuration.

wigsaparelli
wigsaparelli approved these changes Jan 19, 2024
View reviewed changes
Copy link

@wigsaparelli wigsaparelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some final consistency (terminology and case) comments

@shaswot77 shaswot77 merged commit ec7c6e3 into main Jan 22, 2024
6 checks passed
@shaswot77 shaswot77 deleted the work/ss/dashboard-share branch January 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wigsaparelli wigsaparelli wigsaparelli approved these changes

@clarkd clarkd Awaiting requested review from clarkd

Assignees
No one assigned
Labels
feature New Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaswot77 @wigsaparelli