Fix type parameter for expectWorker accepting Worker instance. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e041de0 to
3455e30
Compare
tehras
approved these changes
Feb 18, 2020
The worker type should be unbounded, _not_ the same as the _Workflow's_ output type.
3455e30 to
624e3b6
Compare
|
Fixed the |
tehras
approved these changes
Feb 18, 2020
| key: String = "", | ||
| output: EmittedOutput<OutputT>? = null | ||
| output: EmittedOutput<Any?>? = null |
There was a problem hiding this comment.
This is how you "fake" an output from this worker. This type is the type of the output from the worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worker type should be unbounded, not the same as the Workflow's output type.