Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass acceptOutput function to WorkflowNode constructor instead of every tick pass. #916

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Pass acceptOutput function to WorkflowNode constructor instead of every tick pass. #916

merged 1 commit into from
Jan 28, 2020

Conversation

zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jan 25, 2020 •
edited
Loading

This doesn't change any behavior, it is just more efficient: there's no need to
define the function at the tick pass, so this is not only more efficient but also
just easier to read, since there are fewer moving parts.

This is also required for square/workflow-kotlin#762.

@zach-klippenstein zach-klippenstein added the enhancement New feature or request label Jan 25, 2020
@zach-klippenstein
Pass acceptOutput function to WorkflowNode constructor instead of eve…
4f55451 
…ry tick pass.

This doesn't change any behavior, it is just more efficient: there's no need to
define the function at the tick pass, so this is not only more efficient but also
just easier to read, since there are fewer moving parts.

This is also required for #910.
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/extract-update-handler branch from 00011b8 to 4f55451 Compare January 25, 2020 23:45
@zach-klippenstein zach-klippenstein changed the title WIP Pass acceptOutput function to WorkflowNode constructor instead of every tick pass. Jan 25, 2020
@zach-klippenstein zach-klippenstein marked this pull request as ready for review January 25, 2020 23:46
zach-klippenstein added a commit that referenced this pull request Jan 25, 2020
@zach-klippenstein
WIP Simplified action queueing implementation.
010f9fc 
Based on #916.

Implements and closes #910.
@zach-klippenstein zach-klippenstein merged commit eeb2fa8 into master Jan 28, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/extract-update-handler branch January 30, 2020 14:30
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhavalshreyas dhavalshreyas dhavalshreyas approved these changes

@kirillzh kirillzh Awaiting requested review from kirillzh

Assignees
No one assigned
Labels
enhancement New feature or request kotlin Affects the Kotlin library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zach-klippenstein @dhavalshreyas