Remove knowledge of child StateT type from compose. #214
Conversation
| @@ -38,7 +38,7 @@ import kotlin.coroutines.experimental.CoroutineContext | |||
| * [Workflow.initialState]. | |||
| */ | |||
| internal class WorkflowNode<InputT : Any, StateT : Any, OutputT : Any, RenderingT : Any>( | |||
There was a problem hiding this comment.
If WorkflowContext.compose no longer knows about StateT, how is WorkflowNode learning about it? Where does it come from?
There was a problem hiding this comment.
It basically doesn't, it's effectively Any. But it doesn't need to in practice. The generic param is basically just there so the Workflow methods all agree.
There was a problem hiding this comment.
Let me see if I understand: the StateT of the root WorkflowNode comes from WorkflowHost.Factory#run$workflow_host. But of every other WorkflowNode in the tree has StateT of Any? Given that, can you push this PR farther and get rid of StateT from WorkflowNode and RealWorkflowContext?
b77591f to
a2b675f
Compare
| return rendering | ||
| } | ||
| ): RenderingT = | ||
| composeWithStateType(workflow as Workflow<InputT, StateT, OutputT, RenderingT>, input) |
There was a problem hiding this comment.
@rjrjr The cast you're looking for is here.
a2b675f to
0945a4c
Compare
|
Declining in favor of #219. |
Closes #213.