Simplify ViewRegistry to act more like a simple map of rendering type to ViewFactory. #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
approved these changes
May 11, 2020
| @@ -27,8 +27,8 @@ import kotlin.reflect.KClass | |||
| * | |||
| * Sets of bindings are gathered in [ViewRegistry] instances. | |||
| */ | |||
| interface ViewFactory<RenderingT : Any> { | |||
| val type: KClass<RenderingT> | |||
| interface ViewFactory<in RenderingT : Any> { | |||
kotlin/workflow-ui/core-android/src/main/java/com/squareup/workflow/ui/ViewRegistry.kt
Outdated
Show resolved
Hide resolved
kotlin/workflow-ui/core-android/src/main/java/com/squareup/workflow/ui/ViewRegistry.kt
Outdated
Show resolved
Hide resolved
… to ViewFactory. `ViewRegistry` is now just responsible for returning a `ViewFactory` for a given rendering type, as well as checking that views returned from the factory have been correctly bound with `bindShowRendering`. `buildView` has been extracted into an extension method on `ViewRegistry`. This change simplifies the responsibility of each `ViewRegistry` implementation. It also makes `ViewRegistry` more flexible for extension. For example, allows a Compose-based `ViewFactory` to detect recursive Compose bindings and stay in Compose instead of jumping back out into the legacy view layer every time.
e97c1f1 to
9ffea7d
Compare
|
UI test failures are installation network exceptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewRegistryis now just responsible for returning aViewFactoryfor a givenrendering type, as well as checking that views returned from the factory have been
correctly bound with
bindShowRendering.buildViewhas been extracted into anextension method on
ViewRegistry.This change simplifies the responsibility of each
ViewRegistryimplementation. Italso makes
ViewRegistrymore flexible for extension. For example, allows aCompose-based
ViewFactoryto detect recursive Compose bindings and stay in Composeinstead of jumping back out into the legacy view layer every time.
Checklist