Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContainerViewController init with AnyWorkflowConvertable #1092

Merged
merged 1 commit into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/*
* Copyright 2019 Square Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#if canImport(UIKit)

import Foundation
import Workflow

extension ContainerViewController {
dhavalshreyas marked this conversation as resolved.
Show resolved Hide resolved
public convenience init<W: AnyWorkflowConvertible>(
workflow: W,
rootViewEnvironment: ViewEnvironment = .empty
) where W.Rendering == ScreenType, W.Output == Output {
self.init(workflow: WrapperWorkflow(workflow), rootViewEnvironment: rootViewEnvironment)
}
}

fileprivate struct WrapperWorkflow<Rendering, Output>: Workflow {
typealias State = Void
typealias Output = Output
typealias Rendering = Rendering

var wrapped: AnyWorkflow<Rendering, Output>

init<W: AnyWorkflowConvertible>(_ wrapped: W) where W.Output == Output, W.Rendering == Rendering {
self.wrapped = wrapped.asAnyWorkflow()
}

func makeInitialState() -> State {
return ()
}

func workflowDidChange(from previousWorkflow: WrapperWorkflow, state: inout State) {
}

func render(state: State, context: RenderContext<WrapperWorkflow>) -> Rendering {
return wrapped
.mapOutput { AnyWorkflowAction(sendingOutput: $0) }
.rendered(with: context)
}
}

#endif
20 changes: 20 additions & 0 deletions swift/WorkflowUI/Tests/ContainerViewControllerTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,26 @@ class ContainerViewControllerTests: XCTestCase {

disposable?.dispose()
}

func test_container_with_anyworkflow() {

let (signal, observer) = Signal<Int, Never>.pipe()
let workflow = MockWorkflow(subscription: signal)
let container = ContainerViewController(workflow: workflow.asAnyWorkflow())

let expectation = XCTestExpectation(description: "Output")

let disposable = container.output.observeValues { value in
XCTAssertEqual(3, value)
expectation.fulfill()
}

observer.send(value: 3)

wait(for: [expectation], timeout: 1.0)

disposable?.dispose()
}
}


Expand Down