Rename ContainerHints to ViewEnvironment to match Swift. #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febc382 to
c67f97e
Compare
rjrjr
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
Missed a few:
~/Development/square/workflow/kotlin zachklipp/viewenvironment git grep ContainerHint -- *.kt
samples/containers/android/src/main/java/com/squareup/sample/container/panel/ScrimContainer.kt: viewConstructor = { initialRendering, initialContainerHints, contextForNewView, _ ->
samples/containers/android/src/main/java/com/squareup/sample/container/panel/ScrimContainer.kt: bindShowRendering(initialRendering, initialContainerHints) { rendering, environment ->
workflow-ui/core-android/src/main/java/com/squareup/workflow/ui/ViewEnvironment.kt:typealias ContainerHints = ViewEnvironment
workflow-ui/core-android/src/main/java/com/squareup/workflow/ui/WorkflowViewStub.kt: * containerHints: ContainerHints
Also, do the *.api files need to be updated?
| "Renamed to ViewEnvironment.", | ||
| replaceWith = ReplaceWith("ViewEnvironment", "com.squareup.workflow.ui.ViewEnvironment") | ||
| ) | ||
| typealias ContainerHints = ViewEnvironment |
There was a problem hiding this comment.
Nice. Should you do the same for the key type?
There was a problem hiding this comment.
I don't think it's used as ubiquitously (at least an order of magnitude less common to define new keys than to reference the container type), so I think we can just update those references immediately.
c67f97e to
ac4fe0d
Compare
Keeps `ContainerHints` around as a deprecated type alias with replacement action. Closes #1000.
ac4fe0d to
38d2d59
Compare
|
Only remaining red shard is an iOS error, this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1000.
Keeps
ContainerHintsaround as a deprecated type alias with replacement action.