Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Kotlin 1.3 #35

Closed
rjrjr opened this issue Dec 3, 2018 · 1 comment
Closed

Move to Kotlin 1.3 #35

rjrjr opened this issue Dec 3, 2018 · 1 comment
Assignees
@zach-klippenstein
Labels
kotlin Affects the Kotlin library. points: 1
Milestone
v0.8.0-kt13

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Dec 3, 2018 •
edited by zach-klippenstein
Loading

AC: Summary

Blocks:
@rjrjr rjrjr added the points: 1 label Dec 3, 2018
@rjrjr rjrjr added this to the Stabilize API milestone Dec 3, 2018
This was referenced Dec 3, 2018
Closed
Closed
@zach-klippenstein zach-klippenstein self-assigned this Dec 3, 2018
@zach-klippenstein zach-klippenstein mentioned this issue Jan 4, 2019
Closed
zach-klippenstein added a commit that referenced this issue Mar 8, 2019
@zach-klippenstein
Kotlin 1.3 - Step 1: Upgrade deps, fix coroutine imports.
6615fb1 
Closes #35.
zach-klippenstein added a commit that referenced this issue Mar 8, 2019
@zach-klippenstein
Kotlin 1.3 - Step 2: Fix warnings.
437006d 
Closes #35.
@zach-klippenstein
Copy link
Collaborator

I made a long-running branch, kotlin-13, so we can do parallel dev and releases for our internal repo while we iron out the kinks.

I also started a fresh branch for the actual upgrade.

TODO:

  • Unit tests are failing.

@zach-klippenstein zach-klippenstein modified the milestones: Cross-platform API Convergence, v0.7.0-kt13 Mar 8, 2019
zach-klippenstein added a commit that referenced this issue Mar 13, 2019
@zach-klippenstein
Kotlin 1.3 - Step 2: Fix warnings.
02985de 
Closes #35.
zach-klippenstein added a commit that referenced this issue Mar 17, 2019
@zach-klippenstein
Revert "Bumps kotlin version to 1.2.71"
0a1c5db 
This reverts commit 8fe6d9d.

Turns out 1.2.71 has a bug that causes desugaring to fail on Android.
Supposed to be fixed in 1.3.

We upgraded to 1.2.71 to fix an issue with mismatched transitive deps
internally, a problem to which we've found a different workaround until
we can upgrade to 1.3 (#35).
zach-klippenstein added a commit that referenced this issue Mar 17, 2019
@zach-klippenstein
Revert "Bumps kotlin version to 1.2.71"
e8e0942 
This reverts the kotlin version change in commit 8fe6d9d.

Turns out 1.2.71 has a bug that causes desugaring to fail on Android.
Supposed to be fixed in 1.3.

We upgraded to 1.2.71 to fix an issue with mismatched transitive deps
internally, a problem to which we've found a different workaround until
we can upgrade to 1.3 (#35).
@zach-klippenstein zach-klippenstein mentioned this issue Mar 17, 2019
Merged
zach-klippenstein added a commit that referenced this issue Mar 17, 2019
@zach-klippenstein
Kotlin 1.3 - Step 1: Upgrade deps, fix coroutine imports, fix tests.
54cc3d5 
Some error handling behavior changed which required changes to how
the library handles exceptions and cancellation, as well as a few
unit test changes.

Closes #35.
zach-klippenstein added a commit that referenced this issue Mar 17, 2019
@zach-klippenstein
Kotlin 1.3 - Step 2: Fix warnings.
e133304 
Closes #35.
@zach-klippenstein zach-klippenstein mentioned this issue Mar 17, 2019
Merged
zach-klippenstein added a commit that referenced this issue Mar 17, 2019
@zach-klippenstein
Kotlin 1.3 - Step 1: Upgrade deps, fix coroutine imports, fix tests.
98db997 
Some error handling behavior changed which required changes to how
the library handles exceptions and cancellation, as well as a few
unit test changes.

Closes #35.
zach-klippenstein added a commit that referenced this issue Mar 17, 2019
@zach-klippenstein
Kotlin 1.3 - Step 2: Fix warnings.
d4c3caf 
Closes #35.
zach-klippenstein added a commit that referenced this issue Mar 18, 2019
@zach-klippenstein
Kotlin 1.3 - Step 1: Upgrade deps, fix coroutine imports, fix tests.
8d79702 
Some error handling behavior changed which required changes to how
the library handles exceptions and cancellation, as well as a few
unit test changes.

Closes #35.
zach-klippenstein added a commit that referenced this issue Mar 18, 2019
@zach-klippenstein
Kotlin 1.3 - Step 2: Fix warnings.
20ae6c0 
Closes #35.
@rjrjr rjrjr mentioned this issue Apr 2, 2019
Closed
@zach-klippenstein zach-klippenstein mentioned this issue Apr 3, 2019
Merged
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zach-klippenstein zach-klippenstein

Labels
kotlin Affects the Kotlin library. points: 1
Projects
None yet
Milestone
v0.8.0-kt13
Development

No branches or pull requests
2 participants
@zach-klippenstein @rjrjr