-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Update Okio to 3.2.0 #7358
Conversation
This version does the right thing for Kotlin Multiplatform and Maven.
Note that this is on the 4.x branch |
Just to confirm, this will end up with depending on |
@honnix with this change the new
If you have anything else in your project that depends on There’s one hazard remaining, which is if your code depends on |
@yschimke any thoughts on forcing a non
|
Yeah that would be great! |
I don't think I understand the effects half as well as you. Your call. |
The idea I think is, as long as okhttp depends on okio (non -jvm one), no matter what okio version user explicitly depends on, it would still be the same artifact and it's up to user to decide which version to choose (usually done by maven enforcer). If we merge this as is, users will need to upgrade to okio 3.2.0 as well. |
@honnix yeah good call. Lemme add that before merging this. |
related #7351 |
@swankjesse What's the status of this, if we need a newer okio, does that also bump Kotlin to 1.7.10 for 4.11.0? |
This version does the right thing for Kotlin Multiplatform
and Maven.