Exclude SpellChecker check on N+ #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ba1a67 to
58fae82
Compare
|
It looks like using build tools 25 requires using JDK 1.8 for compilation, but the current Travis setup attempts a build using 1.7. We seem to be at an impasse. |
97fb2dd to
de670a4
Compare
|
I've tinkered with this more and there's officially no way to get this to pass CI without changing how the CI works. Android v24+ requires building on JDK 1.8, so using JDK 1.7 just won't work. |
|
Get rid of it! /drivebycodereview |
|
Rebase? The build is now on 25 and now only JDK 8. |
The bug seems to have returned, exactly as it was from before.
de670a4 to
bb68757
Compare
|
Hah. I snuck into your fork and did it for you! |
|
Thanks, I'm on vacation so can't work on this right now anyways.
…On Feb 24, 2017 18:17, "Jake Wharton" ***@***.***> wrote:
Hah. I snuck into your fork and did it for you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#658 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAfbIuJ97Ec7SJC6C4sWyaSXz2cj1Cs0ks5rfvSjgaJpZM4K4RjY>
.
|
|
Thanks! |
|
I'm late on this, but in general a leak report would have been nice, and an update to the Google ticket ;) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same bug as found in #4 seems to have returned in Android N.
(I also had to update the build scripts a bit in order to support compilation against N.)