Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retained size to leak reports #260

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Conversation

pyricau
Copy link
Member

@pyricau pyricau commented Aug 28, 2015

Fixes #162

@pyricau
Copy link
Member Author

pyricau commented Jan 5, 2016

AFAIK retained size doesn't account for arrays of objects. Need to add heapdump tests to this PR to demonstrate correct calculations.

@pyricau pyricau force-pushed the py/retained_size_for_realz branch 2 times, most recently from 1baf962 to 266e06f Compare January 6, 2016 21:18
@pyricau pyricau force-pushed the py/retained_size_for_realz branch from 266e06f to 78130af Compare January 7, 2016 11:42
pyricau added a commit that referenced this pull request Jan 7, 2016
@pyricau pyricau merged commit 8dc9528 into master Jan 7, 2016
@pyricau pyricau added this to the 1.4 milestone Jan 7, 2016
@jrodbx jrodbx deleted the py/retained_size_for_realz branch May 12, 2016 08:07
Pengchengxiang pushed a commit to XLibrarys/leakcanary that referenced this pull request Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant