Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type error #56

wants to merge 1 commit into from

Conversation

meyer
Copy link
Contributor

@meyer meyer commented Jun 27, 2023

Problem

I forgot to update the wikipedia demo

Solution

Fix type error in wikipedia.tsx

Result

Vercel doesn't yell at me

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5394754299

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.089%
Totals Coverage Status
Change from base Build 5394704543: 0.0%
Covered Lines: 15801
Relevant Lines: 24117
💛 - Coveralls

qix
qix approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@qix qix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the same, but Wikipedia demo is probably been anyway so fine with this. I'd just make index page point to the BlueSky demo now

Originally didn't want it pointing to the Twitter demo because I knew that was going to break at some point soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qix qix qix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meyer @coveralls @qix