Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add proguard configuration to aar #399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Attempt to add proguard configuration to aar #399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73834d5
Added proguard configuration
emartynov Sep 14, 2018
7b9a195
Configure Gradle to include proguard to aar
emartynov Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions android-database-sqlcipher/proguard-project.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
-optimizationpasses 5
-dontusemixedcaseclassnames
-dontskipnonpubliclibraryclasses
-dontskipnonpubliclibraryclassmembers
-dontpreverify
-verbose
-optimizations !code/simplification/arithmetic,!field/*,!class/merging/*,!code/allocation/variable

-dontwarn javax.annotation.**

-keepclasseswithmembernames class * {
native <methods>;
}

-keepclassmembers enum * {
public static **[] values();
public static ** valueOf(java.lang.String);
}

-keep class * implements android.os.Parcelable {
public static final android.os.Parcelable$Creator *;
}

-keep class net.sqlcipher.** {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is keeping too much. This should be reduced to specific classes/methods/variables.
The reason for supplying Proguard rules in a library is for the clients (developers) to not waste time on examining the library's internals. However, this rule is useless as every developer can come up with such a solution for every library.

*;
}