Omit MySQL checkit() when it cannot be created #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the use of the `checkit()` function from the MySQL triggers that enforce constraints on the `dependencies` table, then modify the deployment of MySQL registry scripts to remove `checkit()` when MySQL is using binary logging and Sqitch is not a super user. Fixes #824, which reports that MySQL with binary logging enabled disallows the creation of `DETERMINISTIC` functions by non-super users. In such a configuration, Sqitch itself functions exactly as before, but `checkit()` is not available for use in verify scripts. Refactor the MySQL engine's `run_upgrade()` method to move the rejiggering of a file to a new method, `_prepare_registry_file`. Teach that method then to remove bits of the script as appropriate to the MySQL version and permissions. Update the MySQL tutorial to note how to add `checkit()` if it's missing.
|
I'm not positive this is the best way to detect in a single query whether the current user is a super user: SELECT md5(super_priv) = md5('Y') FROM mysql.user
WHERE CONCAT(user, '@', host) = current_userIt works, but I don't know what all the wrinkles are. Like, are there conditions when |
33291bd to
93a0d1f
Compare
|
Merged in 93a0d1f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of the
checkit()function from the MySQL triggers that enforce constraints on thedependenciestable, then modify the deployment of MySQL registry scripts to removecheckit()when MySQL is using binary logging and Sqitch is not a super user. Fixes #824, which reports that MySQL with binary logging enabled disallows the creation ofDETERMINISTICfunctions by non-super users. In such a configuration, Sqitch itself functions exactly as before, butcheckit()is not available for use in verify scripts.Refactor the MySQL engine's
run_upgrade()method to move the rejiggering of a file to a new method,_prepare_registry_file. Teach that method then to remove bits of the script as appropriate to the MySQL version and permissions.Update the MySQL tutorial to note how to add
checkit()if it's missing.