PR: Use a function to create and get our temporary directory

[arielrossanigo]

Pull Request Checklist

• Read and followed this repo's Contributing Guidelines
• Based your PR on the latest version of the correct branch (master or 3.x)
• Followed PEP8 for code style
• Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
  modified the spyder/defaults directory, or added new icons/assets
• Wrote at least one-line docstrings for any new functions
• Added at least one unit test covering the changes, if at all possible
• Described your changes and the motivation for them below
• Noted what issue(s) this pull request resolves, creating one if needed

Description of Changes

The main change is that temp folder used by Spyder is not more removed when application closes, mainly because when multiple instances of Spyder are running and one of them is closed, temp folder were remove, and remaining ones didn't detect this action.

Another related change is that, every time temp folder is needed, a function to ensure that the folder exists was created. This was implemented using a function and removing a constant called TEMPDIR. This can cause that another projects or branches that have been using this constant crashes.

Because tempdir is not more removed when application closes, now some code to ensure that files are removed after been used was added. The points where this was done are:

• When closing a client the stderr file is removed (if not related clients remains alive)
• When is_module_installed finish

Issue(s) Resolved

Fixes #7800

[pep8speaks]

Hello @arielrossanigo! Thanks for updating the PR.

• There are no PEP8 issues in the file spyder/app/mainwindow.py !

• In the file spyder/plugins/ipythonconsole.py, following are the PEP8 issues :

Line 56:72: W291 trailing whitespace

• There are no PEP8 issues in the file spyder/plugins/tests/test_ipythonconsole.py !

• There are no PEP8 issues in the file spyder/utils/misc.py !

• In the file spyder/utils/programs.py, following are the PEP8 issues :

Line 427:64: W291 trailing whitespace
Line 428:78: W291 trailing whitespace

• In the file spyder/utils/tests/test_programs.py, following are the PEP8 issues :

Line 117:80: E501 line too long (80 > 79 characters)
Line 122:80: E501 line too long (80 > 79 characters)

• There are no PEP8 issues in the file spyder/widgets/ipythonconsole/client.py !

Comment last updated on September 10, 2018 at 17:05 Hours UTC

[CAM-Gerlach]

Thanks for your contribution! I haven't examined the logic in detail, but while the Travis and CircleCI tests are apparently all failing before the tests run due to an unrelated issue (and so cannot be determined whether they have the same problem), the AppVeyor tests are indeed clearly failing due to this change.

Also, as a fairly substantial change, unless the issue is serious and widespread this should probably go to master, but that's ultimately up to @ccordoba12 so don't change anything yet.

[ccordoba12]

Thanks a lot @arielrossanigo for your contribution!! I'll review it when I get back to Colombia (I'm waiting for my flight in Rio).

I'll take a look at our failing tests there too.

[arielrossanigo]

I've take a look at logs and I've just found two main issues:

• In Windows, when I tried to remove stderr file, it is blocked. I'm trying to figure it out how to fix that.
• The error in Travis and Python 2.7 have to do with monkeypatch. I'm trying to reproduce the environment and fix this issue.

If you already deal with something like that let me know.

[arielrossanigo]

The problem related to monkeypatch was solved.

Now I'm trying to figure it out how to solve the problem with file blocks and Windows... The main issue here is that I cannot find a place where can I close the file safely. I wanna try remove the files at all and replace them with StringIO but I'm not so sure what tests covers the use of stderr file.

[ccordoba12]

@arielrossanigo, please rebase or merge with 3.x. The errors in our tests are fixed now.

[arielrossanigo]

@ccordoba12 Finally I could fix the problems in Windows. Now, the only test failing has nothing to do with this PR.

[CAM-Gerlach]

@arielrossanigo See #7856 , should get fixed soon.

[ccordoba12]

Great job @arielrossanigo!! This is a really great improvement over what we had previously.

Most of my comments are purely cosmetic, with the only important change being the request to move get_stderr_file_handle to utils/misc.py.

[ccordoba12]

Thanks a lot @arielrossanigo! This is a really great contribution!