PR: Implement a workaround to toggle on/off fullscreen mode for Windows systems #7720
Conversation
There was a problem hiding this comment.
Testing this on my Win 8.1 machine, Spyder 3.3.1 indeed has the reported problem (menus not appearing in fullscreen mode), while this branch does not, regardless of whether or not the Help pane was open. Unfortunately, I can't test it on my Win10 box right now since Spyder 4 won't even launch at the moment (unrelated). Other than that, just one minor code style comment from me.
spyder/app/mainwindow.py
Outdated
| | Qt.WindowStaysOnTopHint) | ||
| r = QApplication.desktop().screenGeometry() | ||
| self.setGeometry( | ||
| r.left()-1, r.top()-1, r.width()+2, r.height()+2) |
There was a problem hiding this comment.
Two spaces between binary operators per PEP 8.
|
@jnsebgosselin Also works on Windows 10 (1803) |
Due to limitations of the Windows DWM, compositing is not handled correctly for OpenGL based windows when going into full screen mode, so we need to use this workaround.
bd82296 to
bba556b
Compare
|
I rebased this PR to the 3.x branch as specified by the milestone of Issue #4291 |
|
Tests are failing on AppVeyor because I changed the base branch to 3.x in GitHub after pushing the rebased commits... So the tests simply need to be restarted I think. |
|
@jnsebgosselin I started the rebuild, although you should be able to as well if you link AppVeyor to your Github. |
|
Thanks @CAM-Gerlach. |
Description of Changes
Due to limitations of the Windows DWM, compositing is not handled correctly for OpenGL based windows when going into full screen mode.
To get around this issue, this PR propose to use the workaround described here:
https://bugreports.qt.io/browse/QTBUG-41309
Issue(s) Resolved
Fixes #4291